Repository navigation
fix(a11y): Table sortable keyboard operable - #1241
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: fa8739b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
DreaminDani
reviewed
Oct 2, 2026
DreaminDani
reviewed
Oct 2, 2026
ariser
approved these changes
Oct 7, 2026
XOP
enabled auto-merge (squash)
October 8, 2026 12:24
Contributor
Storybook Preview Deployed✅ Preview URL: https://click-gtn5hm0j0-clickhouse.vercel.app Built from commit: |
Contributor
Chromatic Storybook
Built from commit: Statuses as of the end of the run. The build link shows the live review state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
onClickrender a<button type="button"><th>getsaria-sort, sort icons arearia-hidden, consumeraria-labellands on the buttonLinks and tickets
Good to know
Checklist
Contribution
Display/Table/Sortable, axe panel onSortableandResizableColumnsbuildandbuild-storybookwork locallyNot tested: screen readers (VoiceOver, NVDA), Firefox and Safari, a control-plane run against a local build.
Accessibility
aria-labelWCAG 2.2 checked: 2.1.1 Keyboard, 2.4.7 Focus Visible, 4.1.2 Name, Role, Value, 1.3.1 Info and Relationships, 1.4.11 Non-text Contrast (focus ring). Screen reader announcements were not tested. axe at desktop width reports one pre-existing minor
empty-table-headerfor the actions column<th>; it is outside this change (CUI-317 covers the related action-button focus ring).Screenshots
__table-a11y.mov