Repository navigation
CMLDEV-1740 Treat 401 login failure as InitializationError - #264
Merged
Merged
Conversation
tmikuska
force-pushed
the
CMLDEV-1740-accept-401-login-failure
branch
4 times, most recently
from
October 7, 2026 22:42
08e8694 to
04b9012
Compare
Controllers >= 2.11 return 401 (not 403) for every login failure. On 2.11+, a 401 from the POST authenticate call raises InitializationError; a 401 from any other request (expired/revoked preset JWT or PAT) still raises APIError, so token expiry keeps failing loudly. Controllers before 2.11 keep the 403 rule. The message is now credential-neutral: 'Unable to authenticate, please check your credentials'.
tmikuska
force-pushed
the
CMLDEV-1740-accept-401-login-failure
branch
from
October 13, 2026 09:50
04b9012 to
f5b06ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Controllers >= 2.11 return 401 (not 403) for every login failure. Pick the login-failure status from the controller version (401 for