fix: avoid double free in external typed array creation - #72
Draft
GrapeBaBa wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
TypedArray.fromExternalduplicates the input slice into allocator-owned native storage, then passes that allocation tonapi_create_external_arraybufferwith a finalizer.The existing catch-all frees the allocation for every external ArrayBuffer creation error. Node can return
GenericFailureafter it has already installed or invoked the finalizer, so the catch-all can free an allocation that the finalizer also owns.Ownership boundary
NoExternalBuffersAllowed,PendingException, andCannotRunJS: Node returns before finalizer registration, so free the duplicated buffer and propagate the original errorNode implementation references:
Verification
zig fmt --check src/js/typed_arrays.zigzig build test:zapizig buildpnpm test:js— 120/120pnpm lint:jsgit diff --check origin/mainCoverage limitation
The existing Node addon tests cover the production success paths, but they cannot deterministically inject a post-registration
GenericFailureor count finalizer callbacks. No production mock seam or compatibility path was added for those cases.