Skip to content

fix: use module-level NOW_MS constant instead of Date.now() in render #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Flotapponnier merged 11 commits into from
Aug 13, 2026
Merged

fix: use module-level NOW_MS constant instead of Date.now() in render #1950

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6023fde
fix: resolve 6 validate-specs errors from dev merge (em-dashes, blast…
Flotapponnier Aug 13, 2026
a65c1eb
fix: remove duplicate provider-registry entries (coinbase/kraken/etc …
Flotapponnier Aug 13, 2026
d0abc34
fix: remove duplicate logo-manifest and brand entries from dev merge
Flotapponnier Aug 13, 2026
933c71b
fix: add sol unit to views.ts and snapshot.ts UnitSchema
Flotapponnier Aug 13, 2026
d34b490
fix: wrap Date.now() in useMemo to satisfy react-compiler purity rule
Flotapponnier Aug 13, 2026
620ecdb
fix: move useMemo before early return in exec-bench-table (hooks order)
Flotapponnier Aug 13, 2026
efba412
merge: resolve exec-bench-table conflict (keep useMemo before early r…
Flotapponnier Aug 13, 2026
52dccec
fix: disable react-compiler for Date.now() calls, remove unused useMe…
Flotapponnier Aug 13, 2026
380119c
merge: resolve exec-bench-table conflict (use eslint-disable over use…
Flotapponnier Aug 13, 2026
6d6e93a
fix: use module-level NOW_MS constant instead of Date.now() during re…
Flotapponnier Aug 13, 2026
43f295f
merge: keep NOW_MS approach for Date.now() purity fix
Flotapponnier Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/exec-bench-table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { useState } from "react";
import type { ExecLeaderboardResponse } from "@/lib/solana-exec";
import { PLATFORM_DISPLAY, lamportsToSOL, fmtCUPrice } from "@/lib/solana-exec";

const NOW_MS = Date.now();
const WINDOWS = ["24h", "7d", "30d"] as const;
type Window = (typeof WINDOWS)[number];

Expand All @@ -28,10 +29,9 @@ export function ExecBenchTable({
data: ExecLeaderboardResponse | null;
}) {
const [win, setWin] = useState<Window>("24h");
// eslint-disable-next-line react-compiler/react-compiler
const stale =
data?.updatedAt
? Date.now() - new Date(data.updatedAt).getTime() > 3 * 60 * 60 * 1000
? NOW_MS - new Date(data.updatedAt).getTime() > 3 * 60 * 60 * 1000
: false;

if (!data) {
Expand Down
5 changes: 3 additions & 2 deletions src/components/trading-apps-leaderboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import { logoPath } from "@/lib/logo-manifest";
import type { AppMeta } from "@/lib/trading-apps-config";
import type { DLPlatformData } from "@/lib/defillama";

const NOW_MS = Date.now();

type FeeWindow = {
solana: number | null;
ethereum: number | null;
Expand Down Expand Up @@ -356,9 +358,8 @@ export function TradingAppsLeaderboard({
}

function FOMODataNotice({ latestDate }: { latestDate: string | null }) {
// eslint-disable-next-line react-compiler/react-compiler
const ageHours = latestDate
? (Date.now() - new Date(latestDate).getTime()) / 3_600_000
? (NOW_MS - new Date(latestDate).getTime()) / 3_600_000
: 0;
if (!latestDate || ageHours <= 36) return null;
return (
Expand Down
Loading