Fix edit list modal population for legacy list types - #3288
Open
zackcl wants to merge 1 commit into
Open
Conversation
zackcl
requested review from
bcb37 and
danoswaltCL
and
a balanced review from Copilot
August 13, 2026 13:40
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes legacy list editing by canonicalizing built-in list types and correctly populating modal values.
Changes:
- Adds shared normalization for
IndividualandSegment. - Correctly loads members and referenced public segments during editing.
- Validates write paths and adds regression tests.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
packages/types/src/index.ts |
Exports normalization utilities. |
packages/types/src/Experiment/enums.ts |
Defines canonical list types and normalization. |
packages/frontend/.../common-details-participant-list-table.component.ts |
Normalizes list-type display and checks. |
packages/frontend/.../common-details-participant-list-table.component.html |
Uses normalized segment detection. |
packages/frontend/.../upsert-private-segment-list-modal.component.ts |
Populates edit forms from normalized data. |
packages/frontend/.../segments.model.ts |
Allows context-defined list types in forms. |
packages/frontend/.../segment-list.helper.ts |
Builds edit data and detects missing members. |
packages/frontend/.../segment-list.helper.spec.ts |
Covers normalization and edit-data behavior. |
packages/backend/test/unit/services/SegmentService.test.ts |
Tests persistence normalization. |
packages/backend/test/unit/services/FeatureFlagService.test.ts |
Tests feature-flag list normalization. |
packages/backend/test/unit/services/ExperimentService.test.ts |
Tests canonical legacy inference. |
packages/backend/test/unit/controllers/validators/FeatureFlagListValidator.test.ts |
Tests list-type validation. |
packages/backend/src/api/services/SegmentService.ts |
Normalizes segment list types before saving. |
packages/backend/src/api/services/FeatureFlagService.ts |
Normalizes feature-flag list writes. |
packages/backend/src/api/services/ExperimentService.ts |
Canonicalizes inferred experiment list types. |
packages/backend/src/api/controllers/validators/FeatureFlagListValidator.ts |
Requires string list types. |
packages/backend/src/api/controllers/validators/FeatureFlagImportValidator.ts |
Validates imported list types as strings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
zackcl
marked this pull request as ready for review
August 13, 2026 14:58
bcb37
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3285
Some list responses use lowercase
individualorsegmentvalues, while the Edit List modal expects their canonical casing, leaving the Type and Values fields empty.Changes
IndividualandSegmentlist types across frontend and backend write paths.