Repository navigation
Re-admit latest canary from verified publication completion - #5921
Merged
joelteply merged 1 commit intoNov 11, 2026
Merged
Conversation
joelteply
deleted the
7295effb/publication-completion-must-re-admit-the
branch
November 11, 2026 00:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A merged correction could remain unpublished after its admission skipped an active build: core-binaries run 42898995069 finished successfully, but its configured completion event produced no observed dispatcher run. This advances stabilization so resident fixes can reach automatic adoption; the event-delivery cause remains unproved.
The successful publisher now calls the existing admission owner after all publication jobs succeed. The owner validates the finishing run identity and attempt plus all exact-key manifests before excluding only that run. Every other active publication still blocks, and the next immutable key queues behind existing canary concurrency. Cron, check completion and this handoff share the admission mutex. The superseded publication workflow_run trigger is removed.
Validation: 9 Node tests pass, including newer-key handoff, same-key stop, other active publishers, partial/stale manifests, foreign runs, stale attempts, API errors and real-git build-key resolution. Existing manifest validation is reused, not duplicated. No manual workflow dispatch, deployment or live fixture. Automatic publication and resident recovery remain to be observed after review and merge.