Repository navigation
CI: set Cacti fixture ownership to runner:www-data in Setup Permissions - #50
Merged
Merged
Conversation
Composer runs as the runner user in a later CI step and calls touch() while generating the fixture autoloader; utime() only succeeds for the file owner, so the runner user must own the tree. www-data is retained as group and ownership is handed back before polling. Mirrors the fix in Cacti/plugin_evidence#63. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
There was a problem hiding this comment.
🟢 Approval recommended
The CI fixture ownership change has no active review issues.
No open issues 🎉
What changed in this PR
Updates CI fixture ownership so Composer runs as the file owner when generating the Cacti autoloader, while retaining www-data group access.
Changes:
- Changes fixture ownership from
www-data:runnertorunner:www-data. - Adds a comment explaining the ownership requirement and later handoff to
www-data.
| File | Description |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Adjusts fixture ownership in Setup Permissions and documents why. |
Review effort: Balanced
somethingwithproof
approved these changes
Nov 3, 2026
somethingwithproof
left a comment
somethingwithproof
left a comment
Member
There was a problem hiding this comment.
No blockers found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Aligns the
Setup Permissionsstep of the plugin CI workflow with the fix from Cacti/plugin_evidence#63.The step previously chowned the Cacti fixture tree to
www-data:runner. Composer runs as therunneruser in a later step and callstouch()while generating the fixture autoloader;utime()only succeeds for the file owner, so therunneruser must own the tree. This changes ownership torunner:www-data(www-dataretained as the group), with an explanatory comment.Change
Fleet-wide consistency update across
plugin_*repositories.Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com