Skip to content

fix: 릴리즈 리뷰 반영 (3개월 하한 월말 롤오버 클램프, 시드 포맷) - #274

Merged
chanwoo7 merged 1 commit into
developfrom
fix/release-review-cutoff-and-format
Sep 2, 2026
Merged

fix: 릴리즈 리뷰 반영 (3개월 하한 월말 롤오버 클램프, 시드 포맷)#274
chanwoo7 merged 1 commit into
developfrom
fix/release-review-cutoff-and-format

Conversation

@chanwoo7

@chanwoo7 chanwoo7 commented Sep 2, 2026

Copy link
Copy Markdown
Member

릴리즈 PR #272 CodeRabbit 지적 반영 — 알림 3개월 하한의 setMonth 월말 롤오버를 대상 월 말일로 클램프, 시드 파일 Prettier 포맷. API 표면 변경 없음.

릴리즈 PR #272 CodeRabbit 지적 반영 2건.

- 알림 3개월 노출 하한: setMonth 롤오버(5/31 → 3/3)로 하한이 늦어져
  알림이 일찍 숨던 문제 — 롤오버 감지 시 대상 월 말일로 클램프
- prisma/seed/conversations.ts Prettier 포맷(lint 범위 밖 파일)
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 30a77751-fed7-4408-b174-2c7f9c8e1f5e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🧹 knip — dead-code 리포트

Unused dependencies (1)
Duplicate exports (1)
전체 리포트
Unused dependencies (1)
graphql-ws  package.json:63:6
Duplicate exports (1)
KEYWORD_RANK_SNAPSHOT_SIZE|MAX_POPULAR_KEYWORDS_LIMIT  src/features/search/constants/search.constants.ts

청소 후보(오탐 가능) · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

🩺 NestJS Doctor — 90/100 (Excellent)

진단 302건 (error 0).

Category error warning info
architecture 0 0 9
correctness 0 153 0
performance 0 24 17
schema 0 0 86
security 0 13 0
architecture / security 상위 항목
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'IAuditLogRepository'.
  • warning security/security/no-exposed-env-vars: Direct 'process.env.NODE_ENV' access in 'AuthController'. Use ConfigService instead.
  • warning security/security/require-guards-on-endpoints: Endpoint 'start' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'callback' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'refresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'logout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogin' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerRefresh' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'sellerLogout' has no @UseGuards() at class or method level.
  • warning security/security/require-guards-on-endpoints: Endpoint 'devIssueToken' has no @UseGuards() at class or method level.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/conversation/repositories/conversation.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'ConversationRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/order/repositories/order.repository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal type 'OrderRepository'.
  • info architecture/architecture/no-barrel-export-internals: Barrel file re-exports internal module '@/features/product/repositories/product.repository'.

오탐 포함 가능 · 기준 docs/guide/architecture-conventions.md

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 97.68% 5892/6032
🟢 Branches 93.12% 2316/2487
🟢 Functions 96.43% 1163/1206
🟢 Lines 98.26% 5365/5460

Test suite run success

1868 tests passing in 225 suites.

Report generated by 🧪jest coverage report action from 5fbc2c1

@chanwoo7
chanwoo7 merged commit 108f57b into develop Sep 2, 2026
11 checks passed
@chanwoo7
chanwoo7 deleted the fix/release-review-cutoff-and-format branch September 2, 2026 19:02
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...eatures/user/services/user-notification.service.ts 33.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant