Repository navigation
Secure CARDCAP authentication and ownership; add password login and E2E checks - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require signed sessions and consistent contact/image ownership; reject forged identities and cross-user writes, clean up failed extraction images, and return safe upstream errors. Include validated password login/account UI and contact normalization.
Password and magic-link sign-in use independent rate-limit bindings. Playwright builds the frontend before serving tests. Add CI and synthetic real Worker/D1/R2 API/browser coverage with exact persisted/exported assertions.
Validation on ad9b963: 54 unit/security tests, 28 API scenarios, 5 Chromium specs, lint/build passed. Claude explicitly reviewed this SHA on Blackboard sequence 34, conditional on passing CI. Cloudflare remote preview verified native PBKDF2 at 100,000 iterations and wrong-password rejection; no paid AI calls or customer writes.
Deployment requires additive migration 0003_password_auth.sql, verified limiter namespace uniqueness and rollback readiness. Existing README/DEPLOYMENT work remains uncommitted outside this PR.
Limits: 100k PBKDF2 is below the preferred stronger work factor due to the runtime cap; password changes and logout do not revoke previously issued stateless sessions. Strict login quotas may affect shared-IP users. Existing development-tool advisories remain.