Conversation
TahaKhan998
force-pushed
the
fix/issue-970-unminted-ep-number
branch
from
September 28, 2026 09:05
7b20b10 to
aabff75
Compare
kpsherva
reviewed
Sep 28, 2026
| return list( | ||
| retrieve_identifiers( | ||
| stream_entry.entry.get("metadata", {}).get("identifiers", []), | ||
| "apprn", |
Contributor
There was a problem hiding this comment.
could you make sure the mapper will store it with correct scheme (apprn)? Because the only test you are adding here is the validator test, not the correct mapping
Author
There was a problem hiding this comment.
The mapping test is already covered here: https://github.com/CERNDocumentServer/cds-rdm/blob/master/site/tests/inspire_harvester/test_transformer.py#L273
I also added one test on this PR that runs the mapper and then the pidstore rule, so you can see that path here too.
TahaKhan998
force-pushed
the
fix/issue-970-unminted-ep-number
branch
from
September 29, 2026 12:38
aabff75 to
5ed5120
Compare
zzacharo
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #970
if inspire sends a cern-ep approval number that was never minted in cds pidstore, the harvester errors so curators can see someone may be bypassing the cds ep workflow.