Skip to content

fix(fap): Return organizational author and de-duplicate FAP dept author - #624

Open
sakshamarora1 wants to merge 1 commit into
CERNDocumentServer:masterfrom
sakshamarora1:fix/fap_creators
Open

sakshamarora1 wants to merge 1 commit into
CERNDocumentServer:masterfrom
sakshamarora1:fix/fap_creators

Conversation

@sakshamarora1

Copy link
Copy Markdown
Contributor

For handling non person authors in the FAP collection

# {'type': 'organizational', 'name': 'IPT Department'}
002160751 100__ $$aDepartment, IPT$$uIPT
002160751 710__ $$5FAP
002160751 710__ $$aCERN. Geneva. FAP Department

# Skips because 710 exists for all with "CERN FAP Department"
002155573 100__ $$aDepartment, FAP$$uFAP
002155573 710__ $$5FAP
002155573 710__ $$aCERN. Geneva. FAP Department

# {'type': 'organizational', 'name': 'External Funding'}
002140837 100__ $$aFunding, External$$uFAP
002140837 710__ $$5FAP
002140837 710__ $$aCERN. Geneva. FAP Department

# {'type': 'organizational', 'name': 'Knowledge Transfer'}
002140618 100__ $$aTransfer, Knowledge$$uFAP
002140618 710__ $$5FAP
002140618 710__ $$aCERN. Geneva. FAP Department

last, first = name.split(",")
org = first.strip() + " " + last.strip()
if org == "FAP Department":
raise IgnoreKey("creators")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why explicitly ignoring this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because 710 exists for all records and that is being added as the organization author already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants