feat(north-area): add NA58 to the model - #606
Open
palkerecsenyi wants to merge 8 commits into
Open
palkerecsenyi wants to merge 8 commits into
palkerecsenyi wants to merge 8 commits into
Conversation
kpsherva
reviewed
Sep 21, 2026
kpsherva
approved these changes
Sep 21, 2026
palkerecsenyi
force-pushed
the
north-area
branch
6 times, most recently
from
September 28, 2026 14:51
065ee18 to
7191fa0
Compare
palkerecsenyi
force-pushed
the
north-area
branch
9 times, most recently
from
October 2, 2026 08:28
ba036a5 to
c47b735
Compare
zzacharo
reviewed
Oct 2, 2026
zzacharo
approved these changes
Oct 2, 2026
kpsherva
reviewed
Oct 2, 2026
kpsherva
reviewed
Oct 2, 2026
| return { | ||
| "person_or_org": { | ||
| "type": "personal", | ||
| "name": contact_email, |
Contributor
There was a problem hiding this comment.
Can we try not to store emails in this field since we should avoid exposing them for data privacy reasons?
Could you check with Fleur on what they think?
I would try to deconstruct the email to extract name.surname pattern...
Contributor
There was a problem hiding this comment.
did we check if we have these emails in the system? maybe they are existing users
Contributor
There was a problem hiding this comment.
for the authors we don't need to do this, but yes, we could double check to have more accurate data
palkerecsenyi
force-pushed
the
north-area
branch
from
October 2, 2026 12:25
c47b735 to
60d5796
Compare
palkerecsenyi
force-pushed
the
north-area
branch
from
October 2, 2026 13:08
60d5796 to
187accd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492
773_tand_0are in the "Instructions" tab of the migration curation spreadsheet, so I think that means it is okay to ignore them everywhere.