Skip to content

add(scripts): Add script to rebuild rdm_records_state.json - #592

Open
sakshamarora1 wants to merge 5 commits into
CERNDocumentServer:masterfrom
sakshamarora1:fix/past_stats
Open

sakshamarora1 wants to merge 5 commits into
CERNDocumentServer:masterfrom
sakshamarora1:fix/past_stats

Conversation

@sakshamarora1

Copy link
Copy Markdown
Contributor

fixes: #565

@zzacharo zzacharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run a test for a collection that is correct on production, to verify that the fixed json is identical to the one produced from the migration?

Comment thread scripts/rebuild_records_state.py Outdated
log(f"DONE: legacy_recid={legacy_recid}")


def load_communities_ids(collection, config_files=STREAM_CONFIG_FILES):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just pass the community ids here, and how we produce them, it can depend on the use case. wdyt?

Comment thread scripts/rebuild_records_state.py Outdated
Comment thread scripts/rebuild_records_state.py Outdated

@zzacharo zzacharo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we just need to document how do we run this. Maybe on our migration template? Or in our documentation https://digital-repositories.web.cern.ch/cds/cds-rdm.cern.ch/recipes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

verify past rdm_record_state against the version overwrite bug

2 participants