Fix complementary-filter quaternion interpolation threshold - #234
Open
Daniiiil1 wants to merge 1 commit into
Open
Fix complementary-filter quaternion interpolation threshold#234Daniiiil1 wants to merge 1 commit into
Daniiiil1 wants to merge 1 commit into
Conversation
Daniiiil1
marked this pull request as ready for review
August 9, 2026 13:17
Daniiiil1
force-pushed
the
agent/fix-quaternion-interpolation-threshold
branch
from
August 9, 2026 13:18
3ddda08 to
de4b389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0.9scalar-component threshold when choosing between SLERP and normalized LERPWhy
The complementary-filter paper defines epsilon as 0.9: when the delta quaternion scalar component is greater than epsilon, the correction is small enough for normalized LERP; otherwise the filter uses SLERP. The implementation currently compares against zero, which sends most non-negative, non-small corrections through LERP instead.
Fixes #217.
Reference: Valenti, Dryanovski, and Xiao, Keeping a Good Attitude: A Quaternion-Based Orientation Filter for IMUs and MARGs, equations 48–52.
Validation
git diff --checkcomplementary_filter.cppwith C++17 and-Wall -Wextra -Wpedanticclang-format --dry-run --Werroron the changed C++ filesA full ament test run was not available locally because this machine does not have a ROS 2 installation; the added gtest is intended to run in the repository CI.