You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(renderer): pick the visible composer for the current thread id - #755
Renderer 探针 currentThreadId() 要求 connected composer root 恰好一个,但应用 DOM 常态保留多个已连接的 composer root(含隐藏残留;实测一次会话后即 3 个,随使用增长)。函数在这种常态下恒返回 null,需要账号验证时本地验证页因此无法打开(报 "Open a Codex task before starting verification" → "Could not open the ZCode verification page")。排查 ZCode Start Plan 请求被网关拦截(#754 的根因修复)时实测撞到。
The reason will be displayed to describe this comment to others. Learn more.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
The change selects the sole visible composer when multiple roots are connected. No merge-blocking issue is established.
Pre-merge checks: 4
Check name
Status
Explanation
Title check
标题准确概括了选择可见 composer 以确定当前线程 ID 的主要变更。
Description check
描述说明了问题、实现范围和验证结果,与变更内容相关。
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Tip
🎯 Customize your risk assessments
Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.
✅ Automatic approvals, with your rules
Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
Renderer 探针
currentThreadId()要求 connected composer root 恰好一个,但应用 DOM 常态保留多个已连接的 composer root(含隐藏残留;实测一次会话后即 3 个,随使用增长)。函数在这种常态下恒返回null,需要账号验证时本地验证页因此无法打开(报 "Open a Codex task before starting verification" → "Could not open the ZCode verification page")。排查 ZCode Start Plan 请求被网关拦截(#754 的根因修复)时实测撞到。关联 Issue:N/A
实现范围
packages/renderer-extension/src/renderer-binding-probe.ts:currentThreadId()优先取唯一可见的 composer(可见性判定与同文件questions流程一致:rects 非空、visibility可见、无 hidden/inert/aria-hidden 祖先);仅一个连接 root 时保持原有行为不变;多个可见或零可见时仍返回null,不做猜测。实际执行的验证
macOS 15、ZCode Desktop 3.17.2、codexhost CLI 0.17.3:
currentThreadId()恒为null,验证页打开失败。traceless_passed);单 composer 场景行为与修复前一致。