fix(sites): make ci init workflows deploy and install correctly by jamie-at-bunny · Pull Request #246 · BunnyWay/cli

jamie-at-bunny · 2026-10-07T16:20:39Z

Fixes bunny sites ci init workflows so they deploy and install correctly.

changeset-bot · 2026-10-07T16:20:43Z

🦋 Changeset detected

Latest commit: 7705c8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages

Name	Type
@bunny.net/cli	Patch
@bunny.net/framework-detector	Patch
@bunny.net/cli-darwin-arm64	Patch
@bunny.net/cli-darwin-x64	Patch
@bunny.net/cli-linux-arm64	Patch
@bunny.net/cli-linux-x64	Patch
@bunny.net/cli-windows-x64	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

bunnynet-devops · 2026-10-07T16:22:36Z

@codex review

chatgpt-codex-connector · 2026-10-07T16:22:50Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-07T16:27:35.538559Z	`7705c8d`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7705c8df9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-07T16:27:33Z

+  const candidates =
+    projectRoot === root || rootIsWorkspace
+      ? [projectRoot, root]
+      : [projectRoot];
+  const lockDir = candidates.find((dir) =>
+    LOCKFILES.some((name) => existsSync(join(dir, name))),


Run npm installs where the root lockfile is usable

For a nested npm workspace whose only package-lock.json is at the repository root, this selects the root as lockDir and marks the install as frozen, but the generated job applies defaults.run.working-directory to the child project and emits npm ci there. npm ci does not walk up to the workspace-root lockfile; with npm 11.4.2 it exits with “can only install with an existing package-lock.json” when invoked from such a child. Consequently the newly advertised monorepo workflow fails before building, so the install step must run from lockDir/the repository root or the root lockfile must not be treated as usable from the child.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-07T16:27:33Z

+  const packageManager = await detectPackageManager(lockDir ?? projectRoot);
+  return {
+    packageManager,
+    lockfile: lockDir !== undefined,
+    pnpmVersion:
+      packageManager === "pnpm"
+        ? await pnpmVersion(root, projectRoot, lockDir)


Honor packageManager when no lockfile exists

When lockDir is absent, detectPackageManager(projectRoot) only inspects lockfile names and therefore always falls back to npm, even if package.json declares "packageManager": "pnpm@10" or the repository contains pnpm-workspace.yaml. The generated lockfile-less workflow then emits npm install and npm run build; pnpm/Yarn-specific workspaces or dependency protocols can fail even though this change claims to support lockfile-less projects. Use the package-manager field or workspace marker before falling back to npm.

Useful? React with 👍 / 👎.

chatgpt-codex-connector · 2026-10-07T16:27:33Z

+export async function defaultBranch(root: string): Promise<string> {
+  const ref = await runGit(root, [
+    "symbolic-ref",
+    "--short",
+    "refs/remotes/origin/HEAD",
+  ]);
+  return ref?.replace(/^origin\//, "") || "main";


Refresh the remote default branch before embedding it

refs/remotes/origin/HEAD is only a locally cached symbolic ref, not necessarily the remote's current default branch. I reproduced with Git 2.43.0 that after changing a bare remote from master to main and fetching normally, this command still returns origin/master; Git exposes git remote set-head <name> --auto as a separate operation. Running sites ci init from such a common post-rename clone therefore generates a workflow that listens to the obsolete branch, so pushes to the documented default branch never deploy; resolve the remote HEAD or refresh the cached symref first.

AGENTS.md reference: AGENTS.md:L3-L5

Useful? React with 👍 / 👎.

greptile-apps · 2026-10-07T16:28:01Z

Confidence Score: 3/5

[Medium risk] Fixes CI workflow generation for sites deployment.

Fix branch lookup and lockfile-free pnpm selection before merging; both can leave generated workflows unable to deploy.

Findings

Default-branch pushes can be missed ▶
pnpm projects install with npm ▶
CLI version output lacks tests ▶

Summary

Updates generated Sites workflows to use deploy-site 0.1.1 and the CLI's minor version, select a branch from origin/HEAD, and improve dependency installation.

Adds root-lockfile lookup for workspaces, explicit pnpm versions, and uncached installs without lockfiles.
Adds Python generator installs when requirements.txt is absent.
Default-branch lookup and lockfile-free pnpm selection still leave deployment paths broken.
The new cli_version input needs regression coverage.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Site configuration and project files] --> B[Choose framework and install settings]
  C[Local origin HEAD] --> D[Choose deployment branch]
  B --> E[Render GitHub workflow]
  D --> E
  V[CLI minor version] --> E
  E --> F[Install dependencies and build]
  F --> G[Deploy through deploy-site 0.1.1]

_{Reviews (1) · Last reviewed commit: "fix(sites): make ci init workflows deplo..." · Reviewed by Greptile}

greptile-apps · 2026-10-07T16:28:06Z

+export async function defaultBranch(root: string): Promise<string> {
+  const ref = await runGit(root, [
+    "symbolic-ref",
+    "--short",
+    "refs/remotes/origin/HEAD",
+  ]);
+  return ref?.replace(/^origin\//, "") || "main";


Default-branch pushes can be missed

If origin/HEAD is missing after git init and a push, or stale after GitHub's default branch changes, defaultBranch selects main or the old branch. The generated workflow then ignores pushes to the actual default branch, so they never deploy. Query the remote's current default branch before falling back.

greptile-apps · 2026-10-07T16:28:06Z

+  const packageManager = await detectPackageManager(lockDir ?? projectRoot);
+  return {
+    packageManager,
+    lockfile: lockDir !== undefined,
+    pnpmVersion:
+      packageManager === "pnpm"
+        ? await pnpmVersion(root, projectRoot, lockDir)


pnpm projects install with npm

The lockfile-free path still chooses npm for pnpm projects. detectPackageManager ignores packageManager and pnpm-workspace.yaml, so even a project pinned to pnpm gets npm install. If the workspace uses workspace:* dependencies, npm rejects them and deployment stops at installation. Without a lockfile, use the project's manager pin or workspace configuration before defaulting to npm.

Knowledge Base Used: Framework detection

greptile-apps · 2026-10-07T16:28:06Z

+    ...(opts.cliVersion
+      ? [`          cli_version: ${JSON.stringify(opts.cliVersion)}`]
+      : []),


CLI version output lacks tests

No test covers the new cli_version output. Existing deploy assertions call renderSitesWorkflow without cliVersion, so deleting this output would leave them passing while generated deployments stopped selecting the CLI's minor line. Add tests for a supplied value and for omission when no value is supplied.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

greptile-apps

This review was skipped because it would exceed your organization's monthly flex usage limit. Raise the limit in billing settings or wait until the next billing period resets limits.

fix(sites): make ci init workflows deploy and install correctly

7705c8d

jamie-at-bunny mentioned this pull request Oct 7, 2026

fix(sites): launch fixes for ci init workflows, deploys, uploads, and create/delete recovery #245

Closed

jamie-at-bunny marked this pull request as ready for review October 7, 2026 16:21

chatgpt-codex-connector Bot reviewed Oct 7, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 7, 2026

View reviewed changes

fix(sites): drop the root lockfile fallback from ci init

4a88e7c

greptile-apps Bot reviewed Oct 7, 2026

View reviewed changes

amir-at-bunny approved these changes Oct 8, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix(sites): make ci init workflows deploy and install correctly - #246

fix(sites): make ci init workflows deploy and install correctly#246
jamie-at-bunny wants to merge 2 commits into
mainfrom
sites-ci

jamie-at-bunny commented Oct 7, 2026

Uh oh!

changeset-bot Bot commented Oct 7, 2026

Uh oh!

bunnynet-devops commented Oct 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Uh oh!

greptile-apps Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot Oct 7, 2026

Uh oh!

greptile-apps Bot Oct 7, 2026

Uh oh!

greptile-apps Bot Oct 7, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jamie-at-bunny commented Oct 7, 2026

Uh oh!

changeset-bot Bot commented Oct 7, 2026

🦋 Changeset detected

Uh oh!

bunnynet-devops commented Oct 7, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 3/5

Findings

Summary

Uh oh!

greptile-apps Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot Oct 7, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chatgpt-codex-connector Bot commented Oct 7, 2026 •

edited

Loading

greptile-apps Bot commented Oct 7, 2026 •

edited

Loading