Only take the asarray fast path when blocks are contiguous in the chunk - #724
Merged
FrancescAlted merged 1 commit intoSep 24, 2026
Merged
Conversation
are_partitions_behaved() accepted blocks that divide the chunk but are not C-contiguous runs of it, e.g. (32, 1, 16, 32) in (256, 32, 16, 32). asarray() then wrote C-order chunk data with update_data(), which b2nd reads back block by block, silently scrambling arrays of 16 MB or more. Use the same rule as nchunk_fastpath() in C-Blosc2's b2nd.c. Fixes Blosc#723. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Well seen @jeandet. Thanks! The windows CI failure seems unrelated, so merging. |
FrancescAlted
added a commit
that referenced
this pull request
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #723.
are_partitions_behaved()now only accepts blocks that are contiguous runs of their chunk, using the same rule asnchunk_fastpath()inb2nd.c. The(shape, chunks)check from #698 is unchanged.Tests: the two cases from the issue, plus a contiguous layout that must keep the fast path.
tests/ndarraypasses locally; the only failure is an async test that needs a pytest async plugin I didn't have installed.🤖 Generated with Claude Code