Fix portable example runtime and gate native/browser execution - #174
Draft
proggeramlug wants to merge 4 commits into
Draft
proggeramlug wants to merge 4 commits into
proggeramlug wants to merge 4 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six portable examples could compile yet omit game content or fail during native/browser startup. Move them to the shared loop and cleanup, correct fractional arithmetic and captured/derived coordinates, and preserve public palette/input bindings through initialized exports. Require actual native and browser game-content execution as well as all 20 native links.
Windows linked fixtures now live beside the checkout. Cross-drive temporary projects caused Perry to collapse distinct module names and MSVC to merge generated globals into unusable executables; the compile gate also rejects those collisions on a zero linker exit. Handle denied pointer-lock requests while retaining retry intent, and release a grant arriving after cursor cleanup.
Validation:
c414595e016b37e8087928d6c2b37d282497bf47. Hosted and PR Git trees match.Published report and evidence. Archive SHA-256:
dae76a5658444ae6416410cbeb5c7e85d7f97b44407ac0f39e15b6133dcc06a9.These checks cover startup content and cleanup. Full gameplay/input, the broader canonical runtime matrix, pause/focus, device loss, visible Windows presentation and clean distribution remain open. A separate local grid-line candidate still fails reconstruction bounds and is excluded. This does not complete broader API/compiler or hardware/performance acceptance. No PR merge or npm release is included.
Stacked on #173; relates to #142, #74, #140 and #141.