feat(bindings): expose Elements regtest identity - #176
Open
Abdullah1738 wants to merge 2 commits into
Open
Conversation
Author
|
The only failing check is the Kotlin framework build. It fails while compiling aws-lc-sys 0.41.0 armv7 Android assembly on the macOS runner (unterminated conditional directives in boringssl_prefix_symbols_asm.h); the Rust/C#/C++/Python-wheel and other binding checks pass, and recent runs on the same base and current master are green. I do not have permission to rerun upstream jobs. Could a maintainer please rerun the failed job? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network::regtest_with_genesisbinding constructor;epoch, pegin, and local-client parameters;
This closes a binding gap for callers that connect to an Elements regtest node
whose authenticated genesis and policy asset differ from LWK's compiled default.
It is intentionally not a general custom-Elements-network constructor.
Validation
lwk_bindings --lib: 43 pass, 0 fail, 1 ignored;-D warnings, formatting, and diff checks pass;legacy binding/new runtime compatibility pass.
The existing no-default-feature binding build remains blocked by the same 11
Lightning-gated UniFFI errors on the unchanged base and this branch.