Repository navigation
fix(moonraker): deliver ws callbacks on the GUI thread, fail them on disconnect, fetch spools via the Spoolman proxy - #345
Merged
Conversation
…disconnect, fetch spools via the Spoolman proxy
gmmcosta15
force-pushed
the
fix/amu-1-ws-transport
branch
from
October 13, 2026 15:36
da46b7f to
e4ac90b
Compare
… error shape, retry lost history lookups
RobeMartins
approved these changes
Oct 13, 2026
1 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moonraker ws callbacks run on the GUI thread, pending requests fail on disconnect, spools are fetched through server.spoolman.proxy.
Callback contract: when
send_requestreturns True, the callback runs exactly once on the GUI thread with either the result or{"error": {"code": int, "message": str}}(a Moonraker error, or code -1 for a disconnect), so check for"error"before reading it; when it returns False, the callback never runs and the caller handles the failure.