Skip to content

bugfix: minor bugs across pages after PRs - #341

Merged
gmmcosta15 merged 5 commits into
devfrom
fix/minor-bugs
Oct 2, 2026
Merged

gmmcosta15 merged 5 commits into
devfrom
fix/minor-bugs

Conversation

@RobeMartins

Copy link
Copy Markdown

Description

  • bugfix

BlocksScreen/lib/panels/filamentTab.py

  • revert back if gate >1 lost on a pr

BlocksScreen/lib/panels/utilitiesTab.py

  • removed unnecesarry connection

BlocksScreen/lib/panels/widgets/FilamentTab/spoolmanPage.py

  • decreased maximun height

BlocksScreen/lib/panels/widgets/PrintTab/filesPage.py

  • added minimum height

BlocksScreen/lib/panels/widgets/UtilitiesTab/routinePage.py

  • fixed axis routine check not working

@RobeMartins
RobeMartins requested a review from gmmcosta15 October 1, 2026 14:57
@RobeMartins RobeMartins self-assigned this Oct 1, 2026
@RobeMartins RobeMartins changed the title Fix/minor bugs bugfix: minor bugs across pages after PRs Oct 1, 2026

@gmmcosta15 gmmcosta15 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment

  1. utilitiesTab.py: nothing emits subscribe_config any more. The routine page was the only sender, so the signal declaration and its two connect calls to printer.on_subscribe_config are dead. Remove them.

@gmmcosta15
gmmcosta15 merged commit d2a0f67 into dev Oct 2, 2026
8 checks passed
@gmmcosta15
gmmcosta15 deleted the fix/minor-bugs branch October 2, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants