fix(wasm-utxo): make isShielded nullable and preserve Unified Address on shielded outputs - #365
Merged
veetragjain merged 4 commits intoAug 21, 2026
Conversation
…es on shielded outputs Ticket: CSHLD-1528
veetragjain
force-pushed
the
veetragjain/cshld-1528-preserve-unified-addresses-in-shielded-output-parsing
branch
from
August 21, 2026 09:45
710fa78 to
11d3e33
Compare
veetragjain
marked this pull request as ready for review
August 21, 2026 10:21
Allow WASM serializers to add properties only when their Option values are present, and cover the behavior in a WASM test. Refs: CSHLD-1528
Avoid serializing a null isShielded property for non-Zcash outputs, preserving the distinction between false and unsupported. Refs: CSHLD-1528
Keep parsed outputs coin-agnostic while binding Zcash PSBT parsing to outputs with a required isShielded flag. Refs: CSHLD-1528
OttoAllmendinger
approved these changes
Aug 21, 2026
veetragjain
deleted the
veetragjain/cshld-1528-preserve-unified-addresses-in-shielded-output-parsing
branch
August 21, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addShieldedOutput only stored the raw 43-byte Orchard receiver, so parsing a shielded output back out always reconstructed a single-receiver Unified Address, silently dropping any transparent/Sapling receiver the original UA carried. Add an optional unifiedAddress parameter, validate its Orchard receiver against recipient, and store it verbatim in the PSBT's proprietary map so parsing returns the original UA, receivers and all, even after a serialize/deserialize round-trip.
Ticket: CSHLD-1528