feat(wasm-mps): make message pool safe for E2E-encrypted per-recipient delivery - #364
Merged
Conversation
Logicwax
reviewed
Aug 22, 2026
| ) -> Result<HashMap<u8, Vec<u8>>, MpsError> { | ||
| let mut msg_map: HashMap<u8, Vec<DrvMessage>> = Default::default(); | ||
| for msg in msgs { | ||
| let idx = msg.receiver().ok_or(MpsError::ProtocolError)?; |
There was a problem hiding this comment.
since this uses DrvMessage/ zcash/orchard/redpallas lib stuff, does this mean this function will only be used for that coin? Trying to understand here, is this going to be used for all MPS stuff or just for redpallas ops?
Contributor
Author
There was a problem hiding this comment.
Just for redpallas/orchard/zcash
Logicwax
reviewed
Aug 22, 2026
| ) | ||
| .map(|(v, _)| v) | ||
| .map_err(|_| MpsError::DeserializationError)?; | ||
| for msg in &pool { |
There was a problem hiding this comment.
unbounded, perhaps something like:
if incoming.len() + pool.len() > MAX {
return Err
}
Contributor
Author
There was a problem hiding this comment.
Probably not needed due to serialization sizes, but added to be extra safe
…t delivery Ticket: HSM-548
johnoliverdriscoll
force-pushed
the
HSM-548
branch
from
August 22, 2026 03:03
767779d to
3ade8fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: HSM-548