fix(sdk-api): skip doomed native v1 decrypt attempt in browser - #9535
Merged
pranavjain97 merged 1 commit intoAug 20, 2026
Merged
Conversation
browserify-aes (webpack's node:crypto polyfill) has no AES-CCM mode, so native v1 decrypt fails on every call in a real browser bundle, paying for a wasted PBKDF2 run and logging a warning each time before falling back to SJCL. Detect browser runtime and go straight to SJCL, while still enforcing the iter cap to preserve DoS protection. TICKET: WCN-43
zahin-mohammad
approved these changes
Aug 20, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
browserify-aes (webpack's node:crypto polyfill) has no AES-CCM mode, so native v1 decrypt fails on every call in a real browser bundle, paying for a wasted PBKDF2 run and logging a warning each time before falling back to SJCL. Detect browser runtime and go straight to SJCL, while still enforcing the iter cap to preserve DoS protection.
TICKET: WCN-43