CSHLD-1430: BitGoJS SDK — Add shielded wallet creation support - #9524
Draft
Ranjna-G wants to merge 1 commit into
Draft
CSHLD-1430: BitGoJS SDK — Add shielded wallet creation support#9524Ranjna-G wants to merge 1 commit into
Ranjna-G wants to merge 1 commit into
Conversation
Adds isShielded flag support for custodial wallet creation, enabling shielded Zcash (zec/tzec) wallet generation through wallet-platform. Includes validation to restrict shielded wallets to custodial type and require enterprise parameter. Adds comprehensive test coverage for both success and error cases. Ticket: CSHLD-1430
Contributor
Ranjna-G
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds isShielded flag support for custodial wallet creation, enabling shielded Zcash (zec/tzec) wallet generation through wallet-platform. Includes validation to restrict shielded wallets to custodial type and require enterprise parameter.
Linear: CSHLD-1430
Changes
isShieldedoptional property toGenerateBaseMpcWalletOptionsandGenerateWalletOptionsinterfacesgenerateWalletmethod with validation checksisShieldedflag through to wallet-platform API viacoinSpecificparameterTest Plan
Unit tests added covering:
CLOSES TICKET: CSHLD-1430