Repository navigation
Conversation
When a push/pull on a closed solid reaches its far side, the walls and cap of the extrusion land exactly on pieces of the body's existing faces. Those regions were merged into a single face and kept, so the board stopped being a closed solid and solid tools rejected it. Push/pull now erases these coincident faces, together with the edges and vertices that only they used, whenever the pushed face belongs to a closed shell. Loose surfaces such as a single floor face keep their previous behaviour. Fixes BenchUp3D#39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39.
Problem
When a push/pull goes through the full thickness of a board, the walls and cap of the extrusion land exactly on pieces of the body's existing faces. The extrusion first splits the side and bottom faces along its new edges, and then
raw_facefinds the split piece already there and keeps it as a single face. In the case from the issue, that leaves the triangle on the bottom and the two 10 × 18 mm strips on the sides, so the board is no longer a closed solid andModel::solid_volumerejects it.Change
In
extrude_face, push/pull now collects the walls and cap that coincide with an existing face. If the pushed face belonged to a closed two-manifold shell before the operation, and the coincident region lies inside one of that body's earlier surfaces, the face is erased together with the edges and vertices that only it used. The same reasoning covers a pull that meets another part of the same body, where the shared region becomes internal.The cleanup is limited to closed shells, so loose surfaces such as a single floor face keep their current behaviour. Faces that the extrusion itself creates while connecting its edges, such as the diagonal wall in the issue, are not inside an earlier surface and are kept. Because the change is in
extrude_face, it applies both to the corepush_pulland to the app's Push/Pull tool, which goes throughpush_pull_along.Tests
The new test
full_thickness_push_pull_removes_faces_coincident_with_the_far_sidecovers the corner cut from the issue inside a group, an inset pushed through the board (the hole must stay open), and a half-depth cut that must keep its floor and leave the bottom untouched. The test suites forbenchup-core,benchup-toolsandbenchup-clipass locally, and so do the Push/Pull tests inbenchup-app.