Repository navigation
Conversation
Hold V and move the pointer to orbit without clicking, or hold Shift + V to pan, from every tool. Releasing V resumes the current tool and any pending operation. Cmd/Ctrl + V still pastes, a dimension being typed keeps its letters, and a tap still selects a custom V tool shortcut. Add a persisted Navigation setting, enabled by default, list the gesture in the keyboard shortcuts reference, and show a status hint while orbiting. Closes BenchUp3D#59.
…ld-orbit-all-tools # Conflicts: # crates/benchup-app/src/app_tests.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
As agreed in the issue discussion, this uses hold V + pointer movement instead of Cmd/Ctrl, so it works the same way on every platform and does not collide with Ctrl+click on macOS or with modifier toggles in existing tools.
Behavior
Settings and UI
GeneralSettings, and older saved preferences load with it enabled.Tests
New regression tests cover orbiting and panning from several tools, preserving a pending line and its dimension input, the disabled setting and Cmd+V, tap versus hold with a custom V shortcut, cancelling an interrupted selection click, and persisting the setting without a model edit. They all pass.
The full
benchup-appsuite currently has 29 failing tests onmain. This branch fails exactly the same 29 and adds no new failures.