Skip to content

fix(site): pin legacy feed IDs behind a named base and tighten review follow-throughs - #2926

Merged
joeharris76 merged 1 commit into
developfrom
fix/docs-remediation-review-hardening
Oct 13, 2026
Merged

joeharris76 merged 1 commit into
developfrom
fix/docs-remediation-review-hardening

Conversation

@joeharris76

@joeharris76 joeharris76 commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-throughs from the adversarial review of #2909 (all accepted, none applied until now):

  • website/src/lib/atom.ts: legacy Atom entry IDs now build from a named LEGACY_FEED_ID_BASE instead of an inline hardcoded blog/ segment. Behavior unchanged; pinned by blog-feed.test.ts (19 passed) against the legacy-ID fixture.
  • docs/reference/python-api/result-analysis.md: machine identifier 'recurs' (was 'may recur'); tuning-payload sentence reworded to neutral phrasing with identical meaning (consistency is real behavior). Doc snippet output verified True by executing test coverage (test_public_pseudonym_salt.py).
  • Allowance scope verified already tight (lost-ID and canonical-link items produce different strings that cannot fullmatch the legacy-only rule); added a regression test pinning that both are rejected by canonical-atom-entry-links.
  • Subscriber check: in-repo feed consumers key entries by <id> (site_inventory.py, fixture comparisons); nothing dedups on <link>.

Testing: test_site_parity.py 36 passed; blog-feed.test.ts 19 passed; scoped comment-policy 0 violations; git diff --check clean.

@joeharris76
joeharris76 merged commit 06b65fa into develop Oct 13, 2026
80 of 119 checks passed
@joeharris76
joeharris76 deleted the fix/docs-remediation-review-hardening branch October 13, 2026 01:16

This branch was successfully deployed

1 active deployment
oracle — 2f4e637d Deployed Oct 12, 2026 by joeharris76 via post #396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant