Repository navigation
fix(site): pin legacy feed IDs behind a named base and tighten review follow-throughs - #2926
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-throughs from the adversarial review of #2909 (all accepted, none applied until now):
website/src/lib/atom.ts: legacy Atom entry IDs now build from a namedLEGACY_FEED_ID_BASEinstead of an inline hardcodedblog/segment. Behavior unchanged; pinned byblog-feed.test.ts(19 passed) against the legacy-ID fixture.docs/reference/python-api/result-analysis.md: machine identifier 'recurs' (was 'may recur'); tuning-payload sentence reworded to neutral phrasing with identical meaning (consistency is real behavior). Doc snippet output verified True by executing test coverage (test_public_pseudonym_salt.py).canonical-atom-entry-links.<id>(site_inventory.py, fixture comparisons); nothing dedups on<link>.Testing:
test_site_parity.py36 passed;blog-feed.test.ts19 passed; scoped comment-policy 0 violations;git diff --checkclean.