Repository navigation
feat(tuning): give load-only runs full tuning lifecycle parity - #2925
Open
joeharris76 wants to merge 1 commit into
Open
joeharris76 wants to merge 1 commit into
joeharris76 wants to merge 1 commit into
Conversation
Route tuned load-only runs through the adapter's full setup path (schema, tuning apply, metadata, load with post-load hooks) followed by layout fold, reconciliation, session configuration and ledger read-back, exporting tunings, hashes and ledger evidence into the result. Adapters without the full lifecycle refuse tuned load-only runs with an actionable error instead of claiming tuning without evidence.
Collaborator
Author
|
/oracle-review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the D-4 load-only lifecycle parity gate: tuned load-only runs
(
--phases generate,load) now execute the same apply → load → post-load →reconcile → metadata → ledger/receipt → export path as full runs, so a
load-only bundle never carries a tuned mode without
platform.tuning.Soundness review
This change touches the benchmark lifecycle and result-evidence paths.
Requesting soundness review of the current head before merge. This PR must
not auto-merge.
Soundness questions for the reviewer:
adapter._setup_fresh_database_phasesinstead of calling the nativeloader directly. Confirm no lifecycle side effect (tuned-run marker,
post-load maintenance accounting, per-table timings) is lost or double
counted in load-only mode.
configure_for_benchmarknow runs in load-only mode (session settingsrecorded as session statements). Confirm this is safe for all adapters
in a query-less run.
actionable error. Confirm the refusal message and the untuned fallback
preserve existing behavior (existing SimpleNamespace-adapter tests cover
the legacy path).
Verification
test_load_only_lifecycle_parity.py: real-DuckDB parity test(load-only ledger statements equal the full-run tail), refusal test,
untuned-carries-no-tuning test.
uv run -- python -m pytest -m fast -q: 37,953 passed, 26 skipped.uv run -- ruff check .,ruff format --check .,ty check: clean.make comment-policy-check,make agent-write-preflight: pass.