Repository navigation
Add pinned-notice and dependency-inventory drift guards - #2829
Conversation
![benchbox-oracle[bot]](https://avatars.githubusercontent.com/u/319264189?s=60&v=4){kind=small}
There was a problem hiding this comment.
oracle-review-shadow: failure for 9a25578a3d7727d8c6394bd3fbe8501f1664502a
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (180 code lines exceed 150; touches 2 areas).
Decision: SHIP WITH FIXES.
Reviewer: sol (codex gpt-6.1-sol, effort medium).
The notice drift guard needs required CI wiring before merge. Reviewed the supplied diff and relevant head files using read-only commands; no tests were run.
9a25578 to
27ea9e4
Compare
There was a problem hiding this comment.
oracle-verdict: pending for 27ea9e4d6b09df0aa81176e79724b9f23a4fd915
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (225 code lines exceed 150; touches 3 areas).
Scope: files changed since head 9a25578a3d7727d8c6394bd3fbe8501f1664502a was reviewed.
Reviewers not available
- sol: absent (error)
- luna: absent (error)
- muse: absent (invalid)
- sonnet: skipped: same family as the author (claude)
- agy: disabled (CI authentication and quota output are not yet calibrated, and the workflow has no agy job)
There was a problem hiding this comment.
oracle-verdict: failure for 27ea9e4d6b09df0aa81176e79724b9f23a4fd915
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (225 code lines exceed 150; touches 3 areas).
Decision: SHIP WITH FIXES.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
Prior drift-guard defect D1 is fixed: the drift check now runs in the required comment-policy CI job and in make. One must-fix gate defect remains: the new CI drift step falls back to executing the candidate revision's checker when the base lacks it, letting untrusted PR code decide the gate instead of failing closed like the adjacent comment-policy step.
Verified fixed: D1. Resolve their review threads.
Scope: files changed since head 9a25578a3d7727d8c6394bd3fbe8501f1664502a was reviewed.
Reviewers not available
- sol: absent (error)
- luna: absent (error)
Teach scripts/check_comment_cleanup_scope.py a --check-drift mode that fails when a file carrying a digest pin is modified without updating the pin in quality/comment-cleanup-scope.json, and expose it through make check-comment-scope and make comment-policy-check. Add a pre-commit hook running parse_deps.py --check so pyproject.toml changes without a regenerated dependency-audit-raw.md fail before push.
…p_scope before execution
Addresses oracle review threads on #2829: the pinned-notice drift step now exits 1 when the trusted base checker is absent (no candidate-code fallback) and skips fast when no pinned inputs changed; pinned-notice drift comparison is scoped to LICENSE and COPYRIGHT.md.
Re-ran the prescribed replay at the remediation tree: 112 passed. Updates replay_sha, replay_scope, and recorded counts; prior stamp referenced a feature-branch commit unreachable from develop.
27ea9e4 to
202bff7
Compare
There was a problem hiding this comment.
oracle-verdict: success for 202bff7bf416df4737fdf5d8e1ec8dd41cf917e9
This result supersedes those for earlier heads; their open review threads still apply.
Tier: medium-high (249 code lines exceed 150; touches 3 areas).
Decision: SHIP.
Reviewer: muse (muse muse-spark-1.3-contributor, effort medium).
The pinned-notice drift gate now fails closed: the CI step extracts and runs only the base-revision checker and exits 1 when it is missing, and the new parity test proves the candidate checker never executes in either the missing or unsupported case. No new must-fix defects found in the four changed files.
Verified fixed: D2. Resolve their review threads.
Scope: files changed since head 27ea9e4d6b09df0aa81176e79724b9f23a4fd915 was reviewed.
Pull request was closed
This branch was successfully deployed
1 participant
Teach scripts/check_comment_cleanup_scope.py a --check-drift mode that
fails when a file carrying a digest pin is modified without updating
the pin in quality/comment-cleanup-scope.json, and expose it through
make check-comment-scope and make comment-policy-check.
Add a pre-commit hook running parse_deps.py --check so pyproject.toml
changes without a regenerated dependency-audit-raw.md fail before push.