Repository navigation
Replay the Explorer comparison views and prompt catalog from core through d16a0761b - #29
Merged
Merged
Conversation
…ough d16a0761b Mirror core 9adc8ef38, which broadens the Results Explorer comparison views, adds a per-query run comparison, shows list-price cost estimates for Snowflake and Databricks and retires Dashboards, and core d16a0761b, which updates the landing prompt catalog. The bundle already carries the data these views read. Four files resolve URLs against SITE_ORIGIN instead of the hard-coded production origin, and one capture spec keeps the site's captures path; each is listed with its reason in inventory/replay-allowlist.json. replay-fidelity now treats a file removed in both core and the site as clean, since that is a faithful replay of a core deletion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seeded-path replay of core 9adc8ef38 (BenchBox-dev/benchbox#2922) and d16a0761b (BenchBox-dev/benchbox#2974).
Core 9adc8ef38 broadens the Results Explorer comparison views:
The data side of these changes is already in the published bundle. This replay brings the matching UI.
Core d16a0761b updates the landing prompt catalog. The site copy now matches core's generated catalog, which also brings InfluxDB's managed deployment from core 5be6b2f61 into the site.
Site adaptations, recorded in
inventory/replay-allowlist.json:explorer/src/pages/Compare.tsx,explorer/src/pages/Query.tsx,explorer/src/lib/queryRunComparison.tsandexplorer/src/components/RunReceipt.tsxresolve URLs againstSITE_ORIGIN, not a hard-codedhttps://benchbox.dev, so preview and local builds keep their own origin. The repository-boundary check requires this.explorer/e2e/captures/followup-usability-release.spec.tskeeps writing toexplorer/captures, because the site has no_project/auditstree.scripts/replay-fidelity.mjsused to report a file deleted in both core and the site as blocking. It now reports it asremoved, and a test covers both cases.Verified locally against bundle
site-inputs-9adc8ef38(sha256:55a41b19…):replay-fidelity.mjs --since 06b65fa78 --ref d16a0761b: 154 of 154 files clean.tsc,lint:comments,lint:guard,bundle:verify --offline, explorer typecheck and e2e typecheck, website check, explorer and website unit tests, and the build.