Add Control proxy configuration management - #1596
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c39a934954
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3d948d817d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b3c3735aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c8d35fedbd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4b023c6eac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1217a572e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| private static TaskResult fileIntent(String fileName, String revision, List<String> changes) { | ||
| JsonObject configuration = new JsonObject(); | ||
| configuration.addProperty("domain", "file"); | ||
| configuration.addProperty("fileName", fileName); |
There was a problem hiding this comment.
When the proxy exits after the atomic file publication but before the final result replaces this write-ahead intent, recovery recognizes the installed revision and marks the intent committed unchanged. Because this configuration contains only domain and fileName, the recovered success sent to Control omits the masked content required by docs/control-agent-contract.md:34-39, so Control cannot persist the promised redacted snapshot and may reject an operation whose file was already changed. Rebuild the successful result from fileConfigurationService.read(...) during recovery while retaining only metadata before publication.
AGENTS.md reference: AGENTS.md:L56-L61
Useful? React with 👍 / 👎.
| public final class ControlConnector implements AutoCloseable { | ||
| static final int PROTOCOL_VERSION = 1; | ||
| static final int MAX_RESPONSE_BYTES = 64 * 1024; | ||
| static final int MAX_RESPONSE_BYTES = 4 * 1024 * 1024; |
There was a problem hiding this comment.
For every proxy connector deployment, this changes the enforced response-body limit from 64 KiB to 4 MiB, but docs/control-connector.md:142-149 still states that proxy responses are capped at 64 KiB and explicitly tells operators not to raise that bound. The new proxy-file section later claims a shared 4 MiB envelope, leaving the deployment guide internally contradictory; update the timing-bounds section alongside this protocol-limit change.
AGENTS.md reference: AGENTS.md:L151-L158
Useful? React with 👍 / 👎.
1 participant
Summary
bungeeconfig.ymlControl capability for proxy nodesPaired Control UI/API PR will target
BenCodez/VotingPlugin-Controlfrom the same branch name.Local verification
mvn -B -s /root/dev/.maven-votingplugin-settings.xml -f VotingPlugin/pom.xml clean verify— 520 tests passedgit diff --check— passedCompatibility and safety
config.proxy-files.v1bungeeconfig.ymlpath is accepted