fix: resolve missing collection during icon-block migration - #41
Merged
Merged
Conversation
Legacy blocks with an icon name but no collection were skipped entirely. Look up the name in registered collections, then fall back to mediatheque or icon-pack, and bump to 1.1.2. Co-authored-by: Cursor <cursoragent@cursor.com>
francoistibo
approved these changes
Sep 14, 2026
Keep the icon-block migration fix only; the release number and changelog will be added later. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
beapi/icon-blockmigration skipping icons that have anamebut nocollection(Redmine #92477, follow-up of #90676).icon-pack,theme,mediatheque, then others), then fall back tomediatheque(raw) oricon-pack.MIGRATION.mdand bump the plugin to 1.1.2.Test plan
IconBlockMigrator::build_blockparty_block()for name-onlyicon-itemattrs (nocollection) → convertedblockparty/iconwith lookup or fallback.blockparty/icon.nameis truly missing.beapi/blockparty-iconsto 1.1.2 on UNAF and re-runwp blockparty-icons migrate-from-icon-block --dry-run.Made with Cursor