fix(plugins): Sync FAQ question attribute with Polylang - #37
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockparty/faq-question→questiononpll_blocks_rules_for_attributesso Polylang/Autopoly translates the attribute along with the saved HTML.Context
faq-questionstores the question both as a JSON attribute and in the HTML. Without the Polylang rules, Autopoly only updated the HTML, leaving the attribute in the source language and breaking Gutenberg validation.Test plan
faq-question.questionattribute and<span>HTML are both in EN.