Repository navigation
fix: reject malformed cassette request URIs at load time - #4
Merged
Balanov merged 1 commit intoNov 15, 2026
Merged
Conversation
Balanov
approved these changes
Nov 15, 2026
Balanov
left a comment
Owner
There was a problem hiding this comment.
Thank you for this, and for rejecting at load time rather than at replay time. A cassette that cannot be parsed should never reach the point where it becomes an unreachable replay key and is then written back out as an OpenAPI path.
The whitespace check before url.ParseRequestURI is the part worth keeping. Go's parser accepts a space inside a path, and a recorded request URI with a raw space is not something a server ever sent, so the explicit check is doing real work that the parser alone does not.
Merging this. It ships in the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refuse malformed recorded request URIs in the shared cassette loader, naming the interaction and URI before replay, verify, inspect or export proceeds. Use the standard-library parser plus an explicit raw-whitespace check; valid origin-form and absolute request URIs remain accepted.
Validation: malformed escape and unescaped-space regressions fail on upstream.
go test -count=1 ./...,go test -race -count=1 ./...,go vet ./..., CLI build and the complete offlinebench/proof.pyproof pass with Go 1.27.4. The race run used an isolated Zig C compiler.Fixes #3
AI assistance: Implemented, inspected and tested by an AI coding agent (OpenAI Codex). No independent human review is claimed.