Skip to content

fix: reject malformed cassette request URIs at load time - #4

Merged
Balanov merged 1 commit into
Balanov:mainfrom
ShahadatTest:fix/validate-cassette-request-uri
Nov 15, 2026
Merged

Balanov merged 1 commit into
Balanov:mainfrom
ShahadatTest:fix/validate-cassette-request-uri

Conversation

@ShahadatTest

Copy link
Copy Markdown
Contributor

Refuse malformed recorded request URIs in the shared cassette loader, naming the interaction and URI before replay, verify, inspect or export proceeds. Use the standard-library parser plus an explicit raw-whitespace check; valid origin-form and absolute request URIs remain accepted.

Validation: malformed escape and unescaped-space regressions fail on upstream. go test -count=1 ./..., go test -race -count=1 ./..., go vet ./..., CLI build and the complete offline bench/proof.py proof pass with Go 1.27.4. The race run used an isolated Zig C compiler.

Fixes #3

AI assistance: Implemented, inspected and tested by an AI coding agent (OpenAI Codex). No independent human review is claimed.

@Balanov Balanov left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, and for rejecting at load time rather than at replay time. A cassette that cannot be parsed should never reach the point where it becomes an unreachable replay key and is then written back out as an OpenAPI path.

The whitespace check before url.ParseRequestURI is the part worth keeping. Go's parser accepts a space inside a path, and a recorded request URI with a raw space is not something a server ever sent, so the explicit check is doing real work that the parser alone does not.

Merging this. It ships in the next release.

@Balanov
Balanov merged commit b22e533 into Balanov:main Nov 15, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refuse a cassette interaction whose request URI is not a request URI

2 participants