Repository navigation
fix: clipboard-only Copy as Image with a share-ready snippet; clean selections (no line numbers, no blame interference) - #7
Closed
jkyberneees wants to merge 10 commits into
Closed
jkyberneees wants to merge 10 commits into
jkyberneees wants to merge 10 commits into
Conversation
… align wide glyphs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…rations without a regex The Ubuntu runner timed out at bun's 5 s default on a cold swiftc start, and CodeQL js/incomplete-sanitization flagged the regex-built property matcher. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s keep their selection
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
jkyberneees
changed the title
| return this.childNodes.filter((c) => c.nodeType === 1); | ||
| } | ||
| get textContent(): string { | ||
| return this.nodeType === 3 ? this.data : this.childNodes.map((c) => c.textContent).join("") + (this.html ? this.html.replace(/<[^>]*>/g, "") : ""); |
| return this.childNodes.filter((c) => c.nodeType === 1); | ||
| } | ||
| get textContent(): string { | ||
| return this.nodeType === 3 ? this.data : this.childNodes.map((c) => c.textContent).join("") + (this.html ? this.html.replace(/<[^>]*>/g, "") : ""); |
Contributor
Author
|
Superseded: Copy as Image is being dropped. main will return to the 1.5.0 code, with text copy and selection improvements (no line numbers in selections, the blame label no longer interferes with dragging) in a new PR. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy as Image: clipboard-only, share-ready snippet; line numbers never join a selection
Follow-up to 1.6.0 from user feedback: "selecting text with the mouse is still selecting line numbers", and "copy as image MUST copy to clipboard only - adding snippet style, ready to share in social apps".
What
user-select: none, which WebKit ignores. The macOS app is a WKWebView, so dragging selected and highlighted the line numbers. Everyuser-select: nonenow also has-webkit-user-select: none, and those elements get a transparent::selectionas a backstop. A CSS test pins this.How it was checked
swiftc -parsepasses forpackaging/macos/main.swift.How to test
Known limitation
A combining accent is drawn over the next character if a syntax-highlighting token boundary falls exactly between it and its base letter. That is very rare in practice.
🤖 Generated with Claude Code