Repository navigation
fix(theme): buttons follow the theme, and system follows macOS - #20
Merged
Merged
Conversation
A transition started by a theme change does not advance while WebKit is not rendering. After a switch in a hidden or minimized window the page was in the new theme while the title bar buttons kept the old colour. Theme switches now run with transitions off and commit their styles before they return. In the Mac app "system" read back the page's own last choice, because prefers-color-scheme follows the window and the window's appearance was always forced. System now leaves the appearance unset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title bar buttons could look missing: they were drawn in the previous theme's colour.
.icon-btnkept the old colour on the new background.setDocumentThemenow switches with all transitions off and commits styles before they return.prefers-color-schemefollows the window and the window's appearance was always forced, so "system" read back the page's last choice. It now leaveswindow.appearancenil.Checked in an on-screen
WKWebViewset up like the Mac window, before and after, with computed colours and snapshot pixels. Following macOS was simulated throughNSApp.appearance; the OS setting itself was not flipped. The native toolbar was not captured in the light theme (no Screen Recording permission).🤖 Generated with Claude Code