Repository navigation
Round-7 panel review: security, server, client and accessibility fixes - #10
Merged
Merged
Conversation
Security: git driver overrides go through GIT_CONFIG_KEY/VALUE env so a driver named `a=b` can't dodge the `-c` neutralization; updater pins asset downloads to https + GitHub hosts and caps sums/asset sizes; terminals get a narrow open-only token instead of the session token. Server: /api/raw byte ranges (206/416) and short-read failure; superseded searches end with a flagged done line; editor-style search globs; base branch prefers upstream; rootIgnored for ignored subfolders; symlinked dirs indexed once; exited shells kept 60 s for reattach; semver prerelease ordering. Client: ⌘/ help sheet, UI scale follows font size, keyboard splitters, terminal cycling and double-press ⌘W, duplicate-tab folder hints, unreadable-folder rows, offline/reconnect toasts, beforeunload guard; aria-activedescendant on explorer/changes/search/palette, combobox palette, sr-only live regions, terminal role="log", OSC 8 tooltips, reduced-motion and contrast fixes; terminal ZWJ/wide/DECSTR/OSC fixes; CommonMark lazy continuation and multi-line link definitions. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
… prefix
A folder git already flags showed a second identical dot for disk activity.
The PTY tests sent commands before the shell's first prompt, so on Linux the
tty echo landed before the prompt ("# READY") and exact-line waits timed out.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holistic review by a panel (security, server, client, UX/accessibility) with every finding fixed and covered by tests.
GIT_CONFIG_KEY/VALUEenv (a driver nameda=bescaped-c), updater pinned to https + GitHub hosts with size caps, terminals get a narrow open-only token./api/rawbyte ranges, superseded searches flagged, editor-style globs, upstream-first base detection,rootIgnored, symlinked dirs indexed once, exited shells reattachable for 60 s, semver prerelease ordering.beforeunloadguard.aria-activedescendantin explorer/changes/search/palette, combobox palette, live regions, terminalrole="log", OSC 8 tooltips, reduced-motion and contrast fixes.Tests: 1244 pass, 0 fail. Details in DESIGN.md §16.
🤖 Generated with Claude Code