Skip to content

Round-7 panel review: security, server, client and accessibility fixes - #10

Merged
jkyberneees merged 2 commits into
mainfrom
review/round-7-panel
Oct 30, 2026
Merged

jkyberneees merged 2 commits into
mainfrom
review/round-7-panel

Conversation

@jkyberneees

Copy link
Copy Markdown
Contributor

Holistic review by a panel (security, server, client, UX/accessibility) with every finding fixed and covered by tests.

  • Security: git driver neutralization via GIT_CONFIG_KEY/VALUE env (a driver named a=b escaped -c), updater pinned to https + GitHub hosts with size caps, terminals get a narrow open-only token.
  • Server: /api/raw byte ranges, superseded searches flagged, editor-style globs, upstream-first base detection, rootIgnored, symlinked dirs indexed once, exited shells reattachable for 60 s, semver prerelease ordering.
  • Client / UX: ⌘/ help sheet, chrome scales with font size, keyboard splitters, terminal cycling and double-press ⌘W, duplicate-tab folder hints, unreadable-folder rows, offline toasts, beforeunload guard.
  • Accessibility: aria-activedescendant in explorer/changes/search/palette, combobox palette, live regions, terminal role="log", OSC 8 tooltips, reduced-motion and contrast fixes.
  • Terminal / Markdown: ZWJ, wide-char, DECSTR and OSC fixes; CommonMark lazy continuation and multi-line link reference definitions.

Tests: 1244 pass, 0 fail. Details in DESIGN.md §16.

🤖 Generated with Claude Code

Security: git driver overrides go through GIT_CONFIG_KEY/VALUE env so a
driver named `a=b` can't dodge the `-c` neutralization; updater pins
asset downloads to https + GitHub hosts and caps sums/asset sizes;
terminals get a narrow open-only token instead of the session token.

Server: /api/raw byte ranges (206/416) and short-read failure; superseded
searches end with a flagged done line; editor-style search globs; base
branch prefers upstream; rootIgnored for ignored subfolders; symlinked
dirs indexed once; exited shells kept 60 s for reattach; semver
prerelease ordering.

Client: ⌘/ help sheet, UI scale follows font size, keyboard splitters,
terminal cycling and double-press ⌘W, duplicate-tab folder hints,
unreadable-folder rows, offline/reconnect toasts, beforeunload guard;
aria-activedescendant on explorer/changes/search/palette, combobox
palette, sr-only live regions, terminal role="log", OSC 8 tooltips,
reduced-motion and contrast fixes; terminal ZWJ/wide/DECSTR/OSC fixes;
CommonMark lazy continuation and multi-line link definitions.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: In progress 🔵

View logs ↗
db5ceb6 2026-10-30T06:35:26.720Z View logs ↗
  • Build: Failed ❌

View logs ↗
3988151 2026-10-30T06:29:15.193Z View logs ↗

… prefix

A folder git already flags showed a second identical dot for disk activity.
The PTY tests sent commands before the shell's first prompt, so on Linux the
tty echo landed before the prompt ("# READY") and exact-line waits timed out.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@jkyberneees
jkyberneees merged commit 41da69a into main Oct 30, 2026
4 of 5 checks passed
@jkyberneees
jkyberneees deleted the review/round-7-panel branch October 30, 2026 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant