Conversation
Tested in "SNT Testing" - COD
irautu-bluesquare
previously requested changes
Aug 7, 2026
irautu-bluesquare
left a comment
Collaborator
There was a problem hiding this comment.
Nice work, mentioned some minor changes, most of them can be added for a future rework if you don't have time now
sPuntinG
requested review from
irautu-bluesquare
and removed request for
irautu-bluesquare
August 10, 2026 08:10
sPuntinG
dismissed
irautu-bluesquare’s stale review
August 12, 2026 06:31
Nothing breaking. Keep comments as suggestions for later. Reviewer on leave and I need to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SNT25-488 --- Reporting nb + r utils of reporting of "A.1 DHIS2 Extract"
https://bluesquare.atlassian.net/browse/SNT25-488
Done
kable()style (it was confusing to have 2 rendering styles, and kable outputs are truncated when too long)Yet to be addressed (not great but not breaking):
### 6.:🤌🏼 # GP (2026-08-06): why do we get "white" (or blank) tiles? Missing data should get a 0% ...routine_databecause at step### 5.it is transformed and overwritten, so if used as is it breaks at point### 7.(hence need to keep the second import from dataset). See comment:⚠️ # GP: need to keep this import and transformation even if repeated from upstream) ...Tested in:
☑️ Also checked: it renders in Orchestrator WebApp html embedded preview
⛙ Important: always merge branch with
Rebaseso changes are replayed on top (avoid re-surfacing of older code)