Skip to content

SNT25-488 (snt_dhis2_extract_report) - #106

Merged
sPuntinG merged 5 commits into
mainfrom
SNT25-488
Aug 12, 2026
Merged

SNT25-488 (snt_dhis2_extract_report)#106
sPuntinG merged 5 commits into
mainfrom
SNT25-488

Conversation

@sPuntinG

@sPuntinG sPuntinG commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

SNT25-488 --- Reporting nb + r utils of reporting of "A.1 DHIS2 Extract"

https://bluesquare.atlassian.net/browse/SNT25-488

Done

  • Cleaned code by replacing set up and config code with equivalent functions from ./code/snt_utils.r
  • changed the display of first table of "Liste des éléments de donnée extraits" (disaggregatedd indicators) to be also not kable() style (it was confusing to have 2 rendering styles, and kable outputs are truncated when too long)
  • changed color of missing values from "tomatoe" to "grey" in plots "Complétude de l'extraction des données de routine au niveau des formations sanitaires"
  • In "6. Disponibilité des données par formation sanitaire (sur la période analysée)" fixed some phrasing that was either wrong ("une valeur non manquante (c’est-à-dire, une donnée rapportée, qu’elle soit nulle ou positive)") or confusiong ("fenetre" for denominator, and phrasing of subtitle).
  • Made y axis start from 0 in all plots to be less dramatic/misleading ...

Yet to be addressed (not great but not breaking):

  • At point ### 6.: 🤌🏼 # GP (2026-08-06): why do we get "white" (or blank) tiles? Missing data should get a 0% ...
  • Double import of routine_data because at step ### 5. it is transformed and overwritten, so if used as is it breaks at point ### 7. (hence need to keep the second import from dataset). See comment: ⚠️ # GP: need to keep this import and transformation even if repeated from upstream) ...

Tested in:

  • 🇨🇩 COD ("SNT Testing")
  • 🇧🇮 BDI ("BDI SNT Process"). Note: current pipeline version is outdated, so I added the utils file manually so I could test the dev version of the reporting ipynb via VS Code (R reporting utils would be pulled if the pipeline was updated and re-run with "Pull scripts"). This way I don't mess up the ws in case they need to use that specific run.

☑️ Also checked: it renders in Orchestrator WebApp html embedded preview


Important: always merge branch with Rebase so changes are replayed on top (avoid re-surfacing of older code)

@irautu-bluesquare irautu-bluesquare left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, mentioned some minor changes, most of them can be added for a future rework if you don't have time now

Comment thread pipelines/snt_dhis2_extract/utils/snt_dhis2_extract_report.r
Comment thread pipelines/snt_dhis2_extract/utils/snt_dhis2_extract_report.r
@sPuntinG
sPuntinG requested review from irautu-bluesquare and removed request for irautu-bluesquare August 10, 2026 08:10
@sPuntinG
sPuntinG dismissed irautu-bluesquare’s stale review August 12, 2026 06:31

Nothing breaking. Keep comments as suggestions for later. Reviewer on leave and I need to merge.

@sPuntinG
sPuntinG merged commit 7deb5e4 into main Aug 12, 2026
@sPuntinG
sPuntinG deleted the SNT25-488 branch August 12, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants