Use source's native media attribute - #78
Merged
Merged
Conversation
It’s now available to use
Electron didn’t respect the media attribute
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for react-visual canceled.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Uses native <source media> handling for responsive videos, improving SSR and reducing client-side logic.
Changes:
- Renders responsive video sources natively and reloads on media-query changes.
- Removes
@react-hook/media-query. - Attempts to configure Cypress to use Chrome.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/LazyVideo/LazyVideoClient.tsx |
Implements native responsive video sources. |
packages/react/package.json |
Removes the media-query dependency. |
yarn.lock |
Removes the dependency lock entry. |
packages/react/cypress.config.ts |
Adds an invalid Chrome selection option. |
packages/next/cypress.config.ts |
Adds an invalid Chrome selection option. |
packages/contentful/cypress.config.ts |
Adds an invalid Chrome selection option. |
packages/sanity-next/cypress.config.ts |
Adds an invalid Chrome selection option. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this: https://bkwld.slack.com/archives/C07FD2HUDHC/p1786994959971829
This is better for SSR and getting videos playing faster. And removes a JS dep (and JS logic)