Skip to content

Sync eng/common directory with azure-sdk-tools for PR 16705 - #50116

Open
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sync-eng-common-MoveSomeInlineScriptsToCheckedInFiles-16705
Open

Sync eng/common directory with azure-sdk-tools for PR 16705#50116
azure-sdk-automation[bot] wants to merge 2 commits into
mainfrom
sync-eng-common-MoveSomeInlineScriptsToCheckedInFiles-16705

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16705 See eng/common workflow

@azure-sdk-automation
azure-sdk-automation Bot requested review from Alan Zimmer (alzimmermsft) and a lite review from Copilot August 12, 2026 17:30
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 12, 2026
@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner August 12, 2026 17:30
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
35 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Refactors Azure DevOps pipeline steps to replace inline PowerShell with reusable scripts for test-proxy setup/startup checks and for staging test results into “llm-artifacts”.

Changes:

  • Replace inline PowerShell in test-proxy pipeline template with PowerShell@2 tasks that call shared scripts.
  • Add new PowerShell scripts to install/start/test the test-proxy and to stage test result files for LLM artifact upload.
  • Update the llm-artifacts upload template (and a PR diff step) to use script files instead of inline PowerShell.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
eng/common/testproxy/test-proxy-tool.yml Switches inline steps to PowerShell@2 tasks invoking shared test-proxy scripts
eng/common/scripts/Test-TestProxyIsAlive.ps1 New script to poll /Admin/IsAlive with retries
eng/common/scripts/Start-TestProxy.ps1 New script to start test-proxy on Windows and set PROXY_PID
eng/common/scripts/Install-TestProxy.ps1 New script to install test-proxy as a dotnet tool, prepend PATH, and set run-proxy variables
eng/common/scripts/Copy-TestResultsToLlmStaging.ps1 New script to stage test results into llm-artifacts and set an upload variable
eng/common/pipelines/templates/steps/upload-llm-artifacts.yml Replaces inline staging logic with Copy-TestResultsToLlmStaging.ps1
eng/common/pipelines/templates/steps/save-package-properties.yml Uses filePath execution for Generate-PR-Diff.ps1 instead of inline script

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/common/scripts/Install-TestProxy.ps1
Comment thread eng/common/scripts/Start-TestProxy.ps1
Comment thread eng/common/scripts/Copy-TestResultsToLlmStaging.ps1
Comment thread eng/common/testproxy/test-proxy-tool.yml
@azure-sdk-automation
azure-sdk-automation Bot force-pushed the sync-eng-common-MoveSomeInlineScriptsToCheckedInFiles-16705 branch from 95976fe to b5aa04e Compare August 12, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants