Fix uAMQP sender close failures - #7356
Open
Johnathan W (j7nw4r) wants to merge 3 commits into
Open
Conversation
added 2 commits
August 18, 2026 17:52
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6dd2b823-ee32-4dae-8a39-431336702c4b
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 6dd2b823-ee32-4dae-8a39-431336702c4b
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes uAMQP sender teardown safety and distinguishes synthetic timeouts from caller cancellation.
Changes:
- Cancels pending transfers before freeing send callback state.
- Avoids holding the connection lock during poll removal.
- Adds timeout handling and an unsettled-send regression test.
Reviewed changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CHANGELOG.md |
Documents the fixes. |
link.h |
Declares transfer cancellation. |
link.c |
Implements pending-delivery cancellation. |
message_sender.c |
Safely tears down unsettled sends. |
message_sender.cpp |
Adjusts open cleanup and timeout reporting. |
message_receiver.cpp |
Distinguishes close timeout from cancellation. |
message_sender_receiver.cpp |
Adds the sender-close regression test. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Johnathan W (j7nw4r)
marked this pull request as ready for review
August 18, 2026 23:32
|
Azure Pipelines: Successfully started running 2 pipeline(s). 8 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7350.
Motivation
uAMQP could free an unsettled send callback before a delayed broker disposition used it. Sender Open cleanup could also wait for polling while it held the connection lock.
Changes
Test plan
message_sender.c:113; this branch passes.azure-core-amqptests and 9 uAMQP-only tests under AddressSanitizer.RetriesAllowlistedEventHubsConditionsandDoesNotRetryOperationCancelledException.