Repository navigation
Add connector trigger enums and defaults for 4.17.1 - #485
Merged
Swapnil Nagar (swapnil-nagar) merged 2 commits intoNov 10, 2026
Merged
Swapnil Nagar (swapnil-nagar) merged 2 commits into
Swapnil Nagar (swapnil-nagar) merged 2 commits into
Conversation
Keep supported string literals alongside runtime delivery-mode and cardinality enums. Emit Webhook and one defaults, preserve Poll validation and host tuning defaults, and update the public API tests and documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Swapnil Nagar (swapnil-nagar)
requested a review
from a team
as a code owner
November 10, 2026 01:27
Rename ConnectorDeliveryMode to DeliveryMode and ConnectorCardinality to Cardinality across runtime exports, public declarations, tests, and documentation. Preserve supported strings, Webhook/one defaults, and version 4.17.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Manvir Kaur (manvkaur)
approved these changes
Nov 10, 2026
Tsuyoshi Ushio (TsuyoshiUshio)
approved these changes
Nov 10, 2026
Tsuyoshi Ushio (TsuyoshiUshio)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Swapnil Nagar (swapnil-nagar)
deleted the
swapnil/connector-trigger-enums-defaults
branch
November 10, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeliveryMode.Webhook/.PollandCardinality.One/.Manyas runtime and TypeScript enums.'Webhook','Poll','one','many'); unsupported and widened arbitrary strings remain type errors.deliveryModeto'Webhook'and omittedcardinalityto'one'in the generated connector binding metadata.package.json,package-lock.json, and the runtime version constant synchronized through the repository's version script.Behavior and compatibility
Both
app.connectorTriggerandtrigger.connectorTriggeruse the defaults, while preserving explicit enum/string choices and leaving caller options unchanged.Polling still requires
connectionandtriggerConfigName, including when the Poll enum is used. Numeric batch/concurrency/scaling options are not defaulted by the library; their host-defined defaults remain intact.Typed connector extension helpers inherit the enum-compatible options through their existing base-options type. No installed dependencies or unrelated local files are included.
Validation
npm run updateVersion -- --version 4.17.1npm run updateVersion -- --validatenpm run buildnpm run minifynpm test: 496 passing, including connector regression coverage and TypeScript 4 public API compatibility.