Skip to content

Add connector trigger enums and defaults for 4.17.1 - #485

Merged
Swapnil Nagar (swapnil-nagar) merged 2 commits into
v4.xfrom
swapnil/connector-trigger-enums-defaults
Nov 10, 2026
Merged

Swapnil Nagar (swapnil-nagar) merged 2 commits into
v4.xfrom
swapnil/connector-trigger-enums-defaults

Conversation

@swapnil-nagar

@swapnil-nagar Swapnil Nagar (swapnil-nagar) commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Export DeliveryMode.Webhook / .Poll and Cardinality.One / .Many as runtime and TypeScript enums.
  • Continue accepting the existing supported string literals ('Webhook', 'Poll', 'one', 'many'); unsupported and widened arbitrary strings remain type errors.
  • Default omitted deliveryMode to 'Webhook' and omitted cardinality to 'one' in the generated connector binding metadata.
  • Update the package version to 4.17.1, keeping package.json, package-lock.json, and the runtime version constant synchronized through the repository's version script.

Behavior and compatibility

Both app.connectorTrigger and trigger.connectorTrigger use the defaults, while preserving explicit enum/string choices and leaving caller options unchanged.

Polling still requires connection and triggerConfigName, including when the Poll enum is used. Numeric batch/concurrency/scaling options are not defaulted by the library; their host-defined defaults remain intact.

Typed connector extension helpers inherit the enum-compatible options through their existing base-options type. No installed dependencies or unrelated local files are included.

Validation

  • npm run updateVersion -- --version 4.17.1
  • npm run updateVersion -- --validate
  • npm run build
  • npm run minify
  • npm test: 496 passing, including connector regression coverage and TypeScript 4 public API compatibility.
  • Verified the normal package entry point exposes the runtime enum values and emits the requested defaults.
  • Strictly compiled the real connector extension's typed/generic helpers against the updated declarations, checking both enum and legacy-string usage and rejection of unsupported strings.
  • No live host or Azure trigger delivery was exercised.

Keep supported string literals alongside runtime delivery-mode and cardinality enums. Emit Webhook and one defaults, preserve Poll validation and host tuning defaults, and update the public API tests and documentation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rename ConnectorDeliveryMode to DeliveryMode and ConnectorCardinality to Cardinality across runtime exports, public declarations, tests, and documentation. Preserve supported strings, Webhook/one defaults, and version 4.17.1.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swapnil-nagar
Swapnil Nagar (swapnil-nagar) merged commit c73f7c1 into v4.x Nov 10, 2026
13 of 15 checks passed
@swapnil-nagar
Swapnil Nagar (swapnil-nagar) deleted the swapnil/connector-trigger-enums-defaults branch November 10, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants