fix: restore article navigator focus when a rebuild removes the focused row - #189
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
document.activeElementis already<body>.Related Issue
Closes #165
Verification
Three focused tests in
article-navigator.test.tsxcover a rebuild that removes the focused row: focus and the tab stop land on the surviving ancestor row; focus parked on a control outside the navigator stays there; focus already on the document body is not claimed. Each was mutation-checked — removing the restore fails the first, removing the held-focus flag fails the third.pnpm check:frontend.Not verified: manual or desktop E2E runs. The unit tests run in happy-dom, which fires no focusout when the focused element unmounts — the behavior the restore depends on — so this has not been confirmed against a real WebView.
Notes
document.activeElement === document.bodyclause is not required by any current test; it is kept so a rebuild that coincides with another surface taking focus (a dialog, say) cannot be overridden.