Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts supercache directory resolution to use the WordPress “home” URL and more robust URL parsing, improving correctness for subdirectory installs and multisite setups (see #613 / #613).
Changes:
- Replaces
site_url()withhome_url()when deriving the permalink-relative cache path. - Uses
wp_parse_url( $permalink, PHP_URL_PATH )instead of string replacement against$wp_cache_home_path. - Enables strict comparison for the
in_array()check against$cached_direct_pages.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kraftbj
force-pushed
the
cherry-pick/613-home-url-supercache-dir
branch
from
April 7, 2026 22:10
34da52d to
65fb755
Compare
…-url-supercache-dir # Conflicts: # wp-cache-phase2.php
The chained isset() rewrite behaved the same as the original and overlaps the multisite refactor in PR 1022.
get_current_url_supercache_dir() now takes the path from the permalink, so the two tests that set $wp_cache_home_path no longer exercise it. Filter home and siteurl instead, which also covers a subsite whose path differs from the main site's.
kraftbj
marked this pull request as ready for review
November 11, 2026 21:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
site_url()withhome_url()inget_current_url_supercache_dir(), since permalinks are relative to the home URL, not the site URL (these differ when WordPress is installed in a subdirectory).wp_parse_url( $permalink, PHP_URL_PATH )to extract the URI path instead of string-replacing with$wp_cache_home_path, which doesn't work reliably in multisite installations.in_array()call, and skip that check whenREQUEST_URIis not set (WP-CLI, cron).get_permalink()does not return a string, instead of passingfalsetostr_contains().SupercacheDirCaseTestthat set$wp_cache_home_pathto filter the home and siteurl options instead. The lowercasing test now uses a site at/Blog, which is the subsite case this fixes: it fails against the old code and passes with this change.Originally proposed by @stodorovic in #613.
See #613
Test plan
get_current_url_supercache_dir()returns the correct path for individual post IDs.