Repository navigation
Conversation
UserMarkdown rendered text from workspace .lsp comments in a trusted MarkdownString, so a command: link in a doc comment could run VS Code commands when clicked. Render it untrusted and add a regression test. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
UserMarkdown rendered @description/@remarks/@param/@example text from the opened .lsp file into a MarkdownString with isTrusted = true. A markdown link such as docs in a doc comment therefore became a clickable link that runs a VS Code command when the user clicks it in the hover.
Fix
Stop marking the user-documentation hover as trusted. That hover contains no command: links of its own, so nothing depends on trust. The other isTrusted sites only render bundled help data and are unchanged.
Testing
Made with Cursor