Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Stopping at the node budget does not explicitly close the underlying streaming SQLAlchemy result, potentially leaving its cursor open while the supplied session remains active.
1 open issue
What changed in this PR
This PR addresses #52 by stopping traversal when the node budget is discovered, reducing unnecessary edge materialization for high-fan-out concepts.
Changes:
- Track discovered nodes and stop edge consumption as soon as
max_nodesis reached. - Add opt-in batched fetching to
KnowledgeGraph.iter_edges. - Test traversal limits, edge closure over returned nodes, and early iterator termination.
| File | Description |
|---|---|
tests/test_traverse.py |
Adds regression tests for capped traversal and streaming options. |
src/omop_graph/graph/traverse.py |
Enforces the discovery budget during expansion and closes edge generators. |
src/omop_graph/graph/kg.py |
Adds optional batched result fetching for edge iteration. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This is to fix issue described in #52
Checklist
breaking,feature,fix,dependencies, orchore)uv run pytest -q)uv run ruff check .)