Skip to content

Support orm-loader 3 and omop-alchemy 3 - #50

Merged
gkennos merged 3 commits into
mainfrom
fix/stack-3-compatibility
Nov 6, 2026
Merged

gkennos merged 3 commits into
mainfrom
fix/stack-3-compatibility

Conversation

@gkennos

@gkennos gkennos commented Nov 6, 2026

Copy link
Copy Markdown
Member

Summary

adding compatibility for orm-loader 3 and omop-alchemy 3 interfaces (in preparation for duckdb graph support)

Checklist

  • Applied exactly one label (breaking, feature, fix, dependencies, or chore)
  • Tests pass locally (uv run pytest -q)
  • Lint passes (uv run ruff check .)

@gkennos gkennos added the breaking Incompatible API change. MAJOR: x+1.y.z label Nov 6, 2026
@gkennos
gkennos requested a review from nicoloesch November 6, 2026 00:49

@nicoloesch nicoloesch left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change requested: Remove the double-wrap of the context manager for the loading of the internal .csv and instead supply the FK verification after the load.

Comment thread src/omop_graph/cli.py Resolved
@gkennos
gkennos requested a review from nicoloesch November 6, 2026 01:55
@gkennos
gkennos merged commit 7b26aaa into main Nov 6, 2026
3 checks passed
@gkennos
gkennos deleted the fix/stack-3-compatibility branch November 6, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Incompatible API change. MAJOR: x+1.y.z

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants