Repository navigation
Domain routing facts, column-role review pack, and cold-start fix - #26
Merged
Merged
Conversation
gkennos
changed the title
gkennos
changed the title
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1. Publish domain routing facts (
groundworkers.omop_domains)A new public module that other components import instead of keeping their own copies:
DOMAIN_TO_TABLE: which CDM table each clinical domain routes to (9 domains)CLASSIFIABLE_DOMAINS: the 6 clinical domainsdomain_classifycan returnNON_CLINICAL:MetadataandIdentifier. These are labels for non-clinical data-dictionary fields, not OMOP domainsDOMAIN_CLASSIFY_OUTPUTS: the union of the two above2. Ship the column-role review pack with Groundworkers
groundcrew-source-column-classificationmoves here from groundcrew-prompts, so it sits next to theColumnRolecontract it describes. It's published through a newohdsi_prompt_registry.packsentry point (groundworkers.prompt_packs).3. Fix the embedding tier on cold start
On the first grounding call after startup, the knowledge graph wasn't built yet, so the embedding tier was left out of the plan and the answer silently fell back to lexical-only.