Skip to content

"Realization" button depends on assets which may or may not exist #1153

Description

@in1tiate

It's bad practice to depend an entire button on the main UI on an effect named "Realization" existing. If you don't have one, the button becomes functionally useless.

I have come up with two solutions.

Proposed Solution A

  • Hard-code the realization effect as an engine feature akin to screenshakes
    • Pro: Requires no server adaptation. The networking from the <=2.6 version of realization is still intact and functional.
    • Pro: Allows for realization to coexist with other effects rather than overwriting them. I have received numerous user complaints about this behavior.
    • Con: Realization is no longer customizable, as in versions <=2.6
    • Con: Realization effect would still exist in most content packs, creating a redundant way of achieving the same effect

Proposed Solution B

  • Embed the realization effect directly into the binary so that it can never be missing from any given installation
    • Pro: Embedded asset system would be useful in the long run
    • Con: Embedded realization would conflict with existing versions, necessitating hierarchical asset resolution (expensive, and we already do a lot of this)
    • Con: Realization still overwrites other effects
    • Con: Realization is no longer customizable, as in versions <=2.6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions